Skip to content

Conversation

@pastorsj
Copy link
Collaborator

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • [x Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #60

What is the new behavior?

We now manage subscriptions using Subjects

Does this PR introduce a breaking change?

[ ] Yes
[x] No

If yes, is the package.json file updated accordingly

Other information

@pastorsj pastorsj self-assigned this Nov 19, 2017
@pastorsj pastorsj added this to the Milestone 5 milestone Nov 19, 2017
@pastorsj
Copy link
Collaborator Author

pastorsj commented Nov 21, 2017

Approved

Approved with PullApprove

@pastorsj pastorsj merged commit 90b5cb3 into master Nov 21, 2017
@pastorsj pastorsj deleted the feature/manage-subscriptions branch November 21, 2017 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant