Skip to content
This repository was archived by the owner on May 3, 2021. It is now read-only.

Conversation

augustuen
Copy link

Fixes #10 by adding missing capitalization of nouns in the german translation. Also does toLowerCase() before the output of capitalise2().

@msix81
Copy link

msix81 commented Jan 4, 2021

Capitalization looks fine, words like "halb" or any number should remain in lower case (as is).

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

@augustuen
Copy link
Author

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

Yup, unless the user specifically chooses all lowercase or all uppercase, the first word will always have the first letter capitalized. That was already built-in and so didn't need to be amended in this PR.

There is still an issue with all worlds title case though, where certain words (like "nach" and "so") aren't capitalized since they're not recognized as separate words.

@augustuen augustuen mentioned this pull request Feb 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong capitalization in the German prefixes

2 participants