-
Notifications
You must be signed in to change notification settings - Fork 12
Change results saving behaviour with results saved by default #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add some test for this @bowni?
I was thinking of running an experiment and checking there is a result file that was created. (and same thing for running a scenario).
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
- Coverage 80.82% 80.76% -0.07%
==========================================
Files 15 15
Lines 3088 3099 +11
==========================================
+ Hits 2496 2503 +7
- Misses 592 596 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Changes:
Fixes #329, #331