Feaute/multi channel color image #237
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ple color channel management split out color utils into its own file
…nts in MultiImageInputSelector and OperationWizard
…tionWizard with limits on channel addition/removal
…sn't unstack range slider and histrogram
… drawn, and fix some issues loading images in analysis view
capetillo
reviewed
Oct 21, 2025
| outputImage = new ImageData(payload.canvas.width, payload.canvas.height) | ||
| const outputImageData = outputImage.data | ||
| const numPixels = payload.canvas.width * payload.canvas.height * 4 | ||
| for (let j = 3; j < numPixels; j += 4) { |
There was a problem hiding this comment.
what's up with these values? magic numbers!
There was a problem hiding this comment.
magic pixel indices. The images are RGBA - 4 channels - and so that loop is just filling in every 4th value which is the alpha to 255. I can add a comment.
capetillo
reviewed
Oct 21, 2025
| if (colors.length > 0) { | ||
| // Set the first images color constributions as the base values | ||
| for (let j = 0; j < sharedArrays[0].length; j++) { | ||
| for (let c = 0; c < 3; c++) { |
There was a problem hiding this comment.
more pixel/color channel indices...
capetillo
reviewed
Oct 21, 2025
| :min-inputs="MIN_COLOR_CHANNELS" | ||
| @insert-image="insertImage" | ||
| @remove-image="removeImage" | ||
| @add-channel="() => { |
There was a problem hiding this comment.
why are these not written as functions in the script?
There was a problem hiding this comment.
not really sure, I guess I'll move them into the script for readability
capetillo
reviewed
Oct 21, 2025
capetillo
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multi color channel Images for Datalab Color Operations
TODO