Remove the @PublishedApi that are no longer needed for the debugger
#4089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to @mvicsokolova, the following entry points are not used by IDEA since 2020: kotlinx.coroutines.debug.internal.StackTraceFrame field callerFrame field stackTraceElement kotlinx.coroutines.StandaloneCoroutine field _state field context kotlinx.coroutines.ChildContinuation field child kotlinx.coroutines.CancellableContinuationImpl field _decision field delegate field resumeMode field submissionTime field context kotlinx.coroutines.DispatchedContinuation field continuation This leaves only the following *internal* entry points: kotlinx.coroutines.debug.internal.DebugCoroutineInfo method getCreationStackTrace() method getState() method lastObservedStackTrace() field context field sequenceNumber field lastObservedFrame field lastObservedThread kotlinx.coroutines.debug.internal.DebugCoroutineInfoImpl method getCreationStackTrace() method getContext() field lastObservedThread field _state field _lastObservedFrame field sequenceNumber kotlinx.coroutines.debug.internal.DebugProbesImpl field INSTANCE method isInstalled$kotlinx_coroutines_debug() method isInstalled$kotlinx_coroutines_core() method enhanceStackTraceWithThreadDump() method dumpCoroutinesInfo() method dumpCoroutinesInfoAsJsonAndReferences() method enhanceStackTraceWithThreadDumpAsJson() kotlinx.coroutines.debug.internal.DebugProbesImpl$CoroutineOwner field info kotlinx.coroutines.CoroutineId field Key method getId() ... the following *public* entry points: kotlinx.coroutines.CoroutineName field Key method getName() kotlinx.coroutines.Job field Key kotlinx.coroutines.CoroutineDispatcher field Key ... and these entry points outside of the library: kotlin.coroutines.CombinedContext method get() kotlin.coroutines.jvm.internal.DebugMetadataKt method getStackTraceElement() method getSpilledVariableFieldMapping() This commit updates the comments and removes the extraneous `@PublishedApi` annotations, giving us more flexibility to change code.
dkhalanskyjb
changed the title
@PublishedApi that are no longer needed@PublishedApi that are no longer needed for the debugger
qwwdfsad
approved these changes
Apr 8, 2024
Corje
pushed a commit
that referenced
this pull request
May 10, 2024
According to @mvicsokolova, the following entry points are not used by IDEA since 2020: kotlinx.coroutines.debug.internal.StackTraceFrame field callerFrame field stackTraceElement kotlinx.coroutines.StandaloneCoroutine field _state field context kotlinx.coroutines.ChildContinuation field child kotlinx.coroutines.CancellableContinuationImpl field _decision field delegate field resumeMode field submissionTime field context kotlinx.coroutines.DispatchedContinuation field continuation This leaves only the following *internal* entry points: kotlinx.coroutines.debug.internal.DebugCoroutineInfo method getCreationStackTrace() method getState() method lastObservedStackTrace() field context field sequenceNumber field lastObservedFrame field lastObservedThread kotlinx.coroutines.debug.internal.DebugCoroutineInfoImpl method getCreationStackTrace() method getContext() field lastObservedThread field _state field _lastObservedFrame field sequenceNumber kotlinx.coroutines.debug.internal.DebugProbesImpl field INSTANCE method isInstalled$kotlinx_coroutines_debug() method isInstalled$kotlinx_coroutines_core() method enhanceStackTraceWithThreadDump() method dumpCoroutinesInfo() method dumpCoroutinesInfoAsJsonAndReferences() method enhanceStackTraceWithThreadDumpAsJson() kotlinx.coroutines.debug.internal.DebugProbesImpl$CoroutineOwner field info kotlinx.coroutines.CoroutineId field Key method getId() ... the following *public* entry points: kotlinx.coroutines.CoroutineName field Key method getName() kotlinx.coroutines.Job field Key kotlinx.coroutines.CoroutineDispatcher field Key ... and these entry points outside of the library: kotlin.coroutines.CombinedContext method get() kotlin.coroutines.jvm.internal.DebugMetadataKt method getStackTraceElement() method getSpilledVariableFieldMapping() This commit updates the comments and removes the extraneous `@PublishedApi` annotations, giving us more flexibility to change code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to @mvicsokolova, the following entry points are not used by IDEA since 2020:
According to https://youtrack.jetbrains.com/issue/IDEA-335375/Change-coroutine-debugger-implementation-to-use-a-new-package#focus=Comments-27-6989405.0-0,
this leaves only the following internal entry points:
... the following public entry points:
... and these entry points outside of the library:
This commit updates the comments and removes the extraneous
@PublishedApiannotations, giving us more flexibility to change code.