Skip to content

Compat isCanBeDeclared usages #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Compat isCanBeDeclared usages #265

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions src/main/kotlin/BinaryCompatibilityValidatorPlugin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import org.gradle.api.artifacts.Configuration
import org.gradle.api.plugins.*
import org.gradle.api.provider.*
import org.gradle.api.tasks.*
import org.gradle.util.GradleVersion
import org.jetbrains.kotlin.gradle.dsl.*
import org.jetbrains.kotlin.gradle.plugin.*
import org.jetbrains.kotlin.gradle.plugin.mpp.KotlinNativeTarget
Expand Down Expand Up @@ -659,7 +660,7 @@ private fun Project.prepareKlibValidationClasspath(): NamedDomainObjectProvider<
it.description = "Runtime classpath for running binary-compatibility-validator."
it.isCanBeResolved = false
it.isCanBeConsumed = false
it.isCanBeDeclared = true
it.isCanBeDeclaredCompat = true
it.isVisible = false
}

Expand All @@ -669,7 +670,7 @@ private fun Project.prepareKlibValidationClasspath(): NamedDomainObjectProvider<
it.description = "Resolve the runtime classpath for running binary-compatibility-validator."
it.isCanBeResolved = true
it.isCanBeConsumed = false
it.isCanBeDeclared = false
it.isCanBeDeclaredCompat = false
it.isVisible = false
it.extendsFrom(dependencyConfiguration)
}
Expand All @@ -689,7 +690,7 @@ private fun Project.prepareJvmValidationClasspath(): NamedDomainObjectProvider<C
it.description = "Runtime classpath for running binary-compatibility-validator."
it.isCanBeResolved = false
it.isCanBeConsumed = false
it.isCanBeDeclared = true
it.isCanBeDeclaredCompat = true
it.isVisible = false
}

Expand All @@ -701,7 +702,7 @@ private fun Project.prepareJvmValidationClasspath(): NamedDomainObjectProvider<C
it.description = "Resolve the runtime classpath for running binary-compatibility-validator."
it.isCanBeResolved = true
it.isCanBeConsumed = false
it.isCanBeDeclared = false
it.isCanBeDeclaredCompat = false
it.isVisible = false
it.extendsFrom(dependencyConfiguration)
}
Expand Down Expand Up @@ -757,3 +758,16 @@ private fun Project.readVersion(): String? {

return version
}

private val Gradle820 = GradleVersion.version("8.2")

/**
* [Configuration.isCanBeDeclared] is introduced in Gradle 8.2, we need to compat older Gradle users.
*/
private var Configuration.isCanBeDeclaredCompat: Boolean
get() = if (GradleVersion.current() >= Gradle820) isCanBeDeclared else true
set(value) {
if (GradleVersion.current() >= Gradle820) {
isCanBeDeclared = value
}
}