Check source sets existence for Klib dump tasks only after compilation #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut source sets depended on klib compilation
shanshin
approved these changes
Apr 3, 2024
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Oct 28, 2024
… after compilation * Added tests * Change dependencies between tasks so that tasks using information about source sets depended on klib compilation Pull request Kotlin/binary-compatibility-validator#210
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 3, 2024
… after compilation * Added tests * Change dependencies between tasks so that tasks using information about source sets depended on klib compilation Pull request Kotlin/binary-compatibility-validator#210
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 13, 2024
… after compilation * Added tests * Change dependencies between tasks so that tasks using information about source sets depended on klib compilation Pull request Kotlin/binary-compatibility-validator#210
shanshin
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Dec 23, 2024
… after compilation * Added tests * Change dependencies between tasks so that tasks using information about source sets depended on klib compilation Pull request Kotlin/binary-compatibility-validator#210 Moved from Kotlin/binary-compatibility-validator@f3b53bb
KotlinBuild
pushed a commit
to JetBrains/kotlin
that referenced
this pull request
Jan 3, 2025
… after compilation * Added tests * Change dependencies between tasks so that tasks using information about source sets depended on klib compilation Pull request Kotlin/binary-compatibility-validator#210 Moved from Kotlin/binary-compatibility-validator@f3b53bb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Source sets may not be final until klib compilation. Dependencies between tasks were updated so that all tasks relying on that info are executed only after klib compilation.
This fix does not solve #209, it will be addressed separately.
Fixes #206