Skip to content

Remove antiope preview header as checks api is now stable #924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged

Remove antiope preview header as checks api is now stable #924

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions lib/Github/Api/Repository/Checks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
namespace Github\Api\Repository;

use Github\Api\AbstractApi;
use Github\Api\AcceptHeaderTrait;
use Github\Exception\MissingArgumentException;

/**
Expand All @@ -13,8 +12,6 @@
*/
class Checks extends AbstractApi
{
use AcceptHeaderTrait;

/**
* @link https://developer.github.com/v3/checks/runs/#create-a-check-run
*
Expand All @@ -32,9 +29,6 @@ public function create($username, $repository, array $params = [])
throw new MissingArgumentException(['name', 'head_sha']);
}

// This api is in preview mode, so set the correct accept-header.
$this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json';

return $this->post('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/check-runs', $params);
}

Expand All @@ -50,9 +44,6 @@ public function create($username, $repository, array $params = [])
*/
public function update($username, $repository, $checkRunId, array $params = [])
{
// This api is in preview mode, so set the correct accept-header.
$this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json';

return $this->patch('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/check-runs/'.rawurlencode($checkRunId), $params);
}

Expand All @@ -68,9 +59,6 @@ public function update($username, $repository, $checkRunId, array $params = [])
*/
public function all($username, $repository, $ref, $params = [])
{
// This api is in preview mode, so set the correct accept-header.
$this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json';

return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/commits/'.rawurlencode($ref).'/check-runs', $params);
}

Expand All @@ -85,9 +73,6 @@ public function all($username, $repository, $ref, $params = [])
*/
public function show($username, $repository, $checkRunId)
{
// This api is in preview mode, so set the correct accept-header.
$this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json';

return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/check-runs/'.rawurlencode($checkRunId));
}

Expand All @@ -102,9 +87,6 @@ public function show($username, $repository, $checkRunId)
*/
public function annotations($username, $repository, $checkRunId)
{
// This api is in preview mode, so set the correct accept-header.
$this->acceptHeaderValue = 'application/vnd.github.antiope-preview+json';

return $this->get('/repos/'.rawurlencode($username).'/'.rawurlencode($repository).'/check-runs/'.rawurlencode($checkRunId).'/annotations');
}
}