Improve to can specify parameters on issue comments api. #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2019 10:40
(cherry picked from commit 9900b21)
acrobat
requested changes
Oct 17, 2019
Collaborator
|
Thanks @t-kuni! And congrats on your first contribution! 🎉 |
Contributor
|
How is this supposed to play nice with ResultPager's fetchAll on the comments->all() method? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had try to get comments which updated after specific date but it couldn't because can't specify
sinceparameters through this library.Github API provide
sinceparameter.https://developer.github.com/v3/issues/comments/#list-comments-on-an-issue
but this library can specify
pageonly.https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/Issue/Comments.php#L39-L56
In this PR, will be able to specify array on 4th argument of Comments#all method.