Change DeployKeys::update method to match GitHub API #797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 10, 2019 12:42
… then create a new one, in accordance with the supported GitHub APIs
… then create a new one, in accordance with the supported GitHub APIs
# Conflicts: # test/Github/Tests/Api/Repository/DeployKeysTest.php
acrobat
approved these changes
Jun 10, 2019
Collaborator
|
I think we can keep this "helper" method for now! Thanks for the fix @mitchdav and congrats on your first contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an inconsistency between the client and the GitHub API, where when trying to
updatea deploy key on a repo, the client simply callspatch, but this is not supported by the GitHub API, so a suitable workaround would instead be to callremoveand thencreate.I have created the pull request that provides this workaround now, and have altered the
DeployKeysTestfile to match.Alternatively, to avoid deciding on this behaviour for the user, you could just remove the
updatemethod entirely, though I imagine this would be a breaking change.