Corrected error handling in case of 502 GitHub response

[sivaschenko]

In case when GitHub returns a 502 response, the structure of returned content is not handled by GithubExceptionThrower correctly and results in the following error:

PHP Fatal error:  Uncaught Error: Wrong parameters for Github\Exception\RuntimeException([string $message [, long $code [, Throwable $previous = NULL]]]) in /var/www/html/vendor/knplabs/github-api/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php:87
Stack trace:
#0 /var/www/html/vendor/knplabs/github-api/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php(87): Exception->__construct(Array, 502)
#1 /var/www/html/vendor/php-http/httplug/src/Promise/HttpFulfilledPromise.php(34): Github\HttpClient\Plugin\GithubExceptionThrower->Github\HttpClient\Plugin\{closure}(Object(GuzzleHttp\Psr7\Response))
#2 /var/www/html/vendor/knplabs/github-api/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php(88): Http\Client\Promise\HttpFulfilledPromise->then(Object(Closure))
#3 /var/www/html/vendor/php-http/client-common/src/PluginClient.php(160): Github\HttpClient\Plugin\GithubExceptionThrower->handleRequest(Object(GuzzleHttp\Psr7\Request), Object(Closure), Object(Closure))
#4 /var/www/html/vendor/php-http/client-common/src/PluginClie in /var/www/html/vendor/knplabs/github-api/lib/Github/HttpClient/Plugin/GithubExceptionThrower.php on line 87

That happen i.e. when trying to do too many GraphQL requests in a short period of time.

See debug screenshot:

Added a proper handling.

[acrobat]

Hi @sivaschenko, thanks for the improvement of the error handling! Can you add a test to verify the behaviour change? Thanks!

[okorshenko]

Hi @acrobat Thank you for review. Could you please suggest what type of tests should be added? (API, integration, etc)

[acrobat]

@okorshenko I would suggest to add a unit test to check the behaviour of the GithubExceptionThrower plugin. For example pass a mocked "correct" request and it shouldn't do anything. And another test with a mocked "error" request, it should perform the correct changed logic for a 502 response.

[sivaschenko]

Hi @acrobat GithubExceptionThrower was covered with a unit test. Happy Christmas! 🎅🏻

[acrobat]

Hi @sivaschenko, really nice testcase you provided there! Thanks for the PR and congrats on your first contribution!

Merry christmas to you!

[sivaschenko]

Thanks for the merge! @acrobat are there any plans/schedule for the next release?

[acrobat]

@sivaschenko I will try to get one out in the next few days!