Skip to content

Make sure we do not break BC by accident #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 5, 2018
Merged

Make sure we do not break BC by accident #734

merged 3 commits into from
Sep 5, 2018

Conversation

@Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Sep 2, 2018

We should automate our check for BC breaks.

@Nyholm Nyholm requested a review from acrobat September 2, 2018 11:39
acrobat
acrobat approved these changes Sep 2, 2018
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build seems to fail due to dependency errors. But a huge 👍 from me as this is a really good feature/check to add! Nice one @Nyholm!

@Nyholm
Copy link
Collaborator Author

Nyholm commented Sep 5, 2018

I removed our legacy php_cs config (that did not work) and removed the styleci-php-cs bridge.

acrobat
acrobat approved these changes Sep 5, 2018
View reviewed changes
Copy link
Collaborator

@acrobat acrobat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@acrobat
Copy link
Collaborator

acrobat commented Sep 5, 2018

Thanks @Nyholm

@acrobat acrobat merged commit c6c0258 into master Sep 5, 2018
@acrobat acrobat deleted the Nyholm-patch-bc branch September 5, 2018 18:53
@Nyholm
Copy link
Collaborator Author

Nyholm commented Sep 5, 2018

Thank you for mergign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acrobat acrobat acrobat approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nyholm @acrobat