Skip to content

Refactoring tests #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2017
Merged

Refactoring tests #664

merged 1 commit into from
Dec 12, 2017

Conversation

@carusogabriel
Copy link
Contributor

@carusogabriel carusogabriel commented Dec 12, 2017

I've refactored some tests, using:

  • assertCount instead of count function;
  • assertInternalType instead of gettype function;
  • assertTrue instead of comparison with true keyword.

Nyholm
Nyholm approved these changes Dec 12, 2017
View reviewed changes
Copy link
Collaborator

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! =)

@Nyholm Nyholm merged commit 633e004 into KnpLabs:master Dec 12, 2017
@carusogabriel carusogabriel deleted the refactoring-tests branch December 12, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carusogabriel @Nyholm