Add Integrations::configure #581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrobat
reviewed
May 8, 2017
lib/Github/Api/Integrations.php
Outdated
| public function configure($bodyType = null) | ||
| { | ||
| if ('raw' === $bodyType) { | ||
| $this->acceptHeaderValue = sprintf('application/vnd.github.%s.raw', $this->client->getApiVersion()); |
Collaborator
There was a problem hiding this comment.
I would just set the required header and leave the additional checks away. See: https://github.com/KnpLabs/php-github-api/blob/master/lib/Github/Api/Project/Cards.php#L20
acrobat
reviewed
May 8, 2017
lib/Github/Api/Integrations.php
Outdated
| use AcceptHeaderTrait; | ||
|
|
||
| /** | ||
| * Configure the accept header for Early Access to the projects api |
Collaborator
There was a problem hiding this comment.
integrations api instead of projects
acrobat
reviewed
May 8, 2017
lib/Github/Api/Integrations.php
Outdated
| /** | ||
| * Configure the accept header for Early Access to the projects api | ||
| * | ||
| * @see https://developer.github.com/v3/repos/projects/#projects |
Collaborator
There was a problem hiding this comment.
Contributor
Author
|
@acrobat Copy-paste errors... fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #580