add the ability to fetch repositories for a specific installation and user #578
Conversation
lib/Github/Api/CurrentUser.php
Outdated
| */ | ||
| public function repositoriesByInstallation($installationId, array $params = array()) | ||
| { | ||
| return $this->get("/user/installations/$installationId/repositories", array_merge(array('page' => 1), $params)); |
There was a problem hiding this comment.
Page is only hardcoded when you don't pass a page array key in the params array. So this is the default value
|
It looks like the styleci job for this PR was not started. You could rebase and force push which should trigger a new build |
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Good.
You also need to add a configure method to set Accept header to application/vnd.github.machine-man-preview+json
lib/Github/Api/CurrentUser.php
Outdated
| */ | ||
| public function repositoriesByInstallation($installationId, array $params = array()) | ||
| { | ||
| return $this->get("/user/installations/$installationId/repositories", array_merge(array('page' => 1), $params)); |
There was a problem hiding this comment.
Lets use sprintf here. Also, do single quotes.
|
@Nyholm I'm not sure about your last comment (the Accept header). I think it's outside of the scope of this PR. If I want to call any route regarding integrations (any method in I see two benefits of not adding it here:
|
I did not know. Thanks.
I do agree with your reasons, but the configure method is needed for consistency.
Yeah, since it is needed for the existing endpoints as well. I created a new issue for that #580 |
|
Thank you for this PR. |
4 participants
https://developer.github.com/early-access/integrations/user-identification-authorization/#check-which-installations-resources-a-user-can-access
@Nyholm @acrobat