Skip to content

Use parameters array instead of inline query param #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2017
Merged

Use parameters array instead of inline query param #546

merged 1 commit into from
Mar 26, 2017
+20 −1

Conversation

@acrobat
Copy link
Collaborator

@acrobat acrobat commented Mar 25, 2017

And extra testcase for the since parameter. Closes #538

@Nyholm Nyholm modified the milestone: Release 2.2 Mar 26, 2017
@Nyholm
Copy link
Collaborator

Nyholm commented Mar 26, 2017

It is a beauty to review your PRs. They are really properly made. Thank you

@Nyholm Nyholm merged commit 48bd26c into KnpLabs:master Mar 26, 2017
@acrobat
Copy link
Collaborator Author

acrobat commented Mar 26, 2017

Thanks @Nyholm :)

@acrobat acrobat deleted the user-param-fix branch March 26, 2017 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Release 2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@acrobat @Nyholm