Bugfix: headers not being passed to request #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
requested changes
Feb 23, 2017
Collaborator
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you for this PR.
I like that you added tests. I just had a minor comment and then Im happy to merge
.gitignore
Outdated
| vendor/* | ||
|
|
||
| # IDEs | ||
| /.idea/ |
Collaborator
There was a problem hiding this comment.
This should never be in the gitignore. They should be in your global gitignore file.
Contributor
Author
There was a problem hiding this comment.
I wasn't familiar with the global gitignore, thanks
Nyholm
approved these changes
Feb 23, 2017
Contributor
|
👍 thanks, I indeed missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that the version header (and any other headers which were set using
addHeaderValue()) were not passed to theHeaderAppendPlugin, so when the request was made those headers didn't get sent.