Skip to content

Conversation

@CorentinRegnier
Copy link
Contributor

At line 55 : change create by update

At line 55 : change create by update
@Nyholm
Copy link
Collaborator

Nyholm commented Aug 8, 2016

Thank you for the PR. Can you tell me why would you like to make this change?

@CorentinRegnier
Copy link
Contributor Author

Because its not running when you use the word "create" at line 55, but if
you use "update" it run.

Le 8 août 2016 15:11, "Tobias Nyholm" [email protected] a écrit :

Thank you for the PR. Can you tell me why would you like to make this
change?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#429 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATzfW-PwisiIX4WNc-jjrn7ZY05b3B9Wks5qdyp1gaJpZM4JfBcc
.

@GrahamCampbell
Copy link
Contributor

That doesn't really explain anything?

@CorentinRegnier
Copy link
Contributor Author

I wanted in my app update a comment connect to my githubs comment, then in
your file comments.md its specified to use the commande :
$client->api('issue')->comments()->create('KnpLabs', 'php-github-api',
33793831, array('body' ='my updated comment')); . This command is not
working but if i write this line :
$client->api('issue')->comments()->update('KnpLabs', 'php-github-api',
33793831, array('body' ='my updated comment')); it's working !

Le 8 août 2016 15:18, "Graham Campbell" [email protected] a écrit :

That doesn't really explain anything?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#429 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATzfW-ZhGVqH-3C_Tj5DFc7fuXoEtKj8ks5qdyyQgaJpZM4JfBcc
.

@Nyholm
Copy link
Collaborator

Nyholm commented Aug 8, 2016

Thank you.
You are correct. In the current documentation under the heading "Update a comment" we have stated that you should run the code

$client->api('issue')->comments()->create()

Which, of course, is wrong.

👍

@CorentinRegnier
Copy link
Contributor Author

You're welcome Nyholm ;)

@cursedcoder cursedcoder merged commit 3e756d1 into KnpLabs:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants