Skip to content

Conversation

@Nyholm
Copy link
Collaborator

@Nyholm Nyholm commented Aug 2, 2016

This is a massive PR but it does nothing but add a slash ("/") infront of all URL.
The reason for this is because Guzzle decided to validate the url as soon as it changes. (guzzle/psr7#94)

We added a url like "user/Nyholm/repos" then we use AddHostPlugin which executes like this:

$uri = $request->getUri()
                ->withHost($this->host->getHost())
                ->withScheme($this->host->getScheme())
                ->withPort($this->host->getPort())
            ;

If we add a host like "api.github.com" it will not be valid at that state. It was before because https://github.com/guzzle/psr7/pull/94/files#diff-db412dbd2c689be753da90d14beffc1bL461

With this PR we make sure to always have a valid URL. Because "/foo" is a valid URL.

@GrahamCampbell
Copy link
Contributor

Sad times...

image

@Nyholm
Copy link
Collaborator Author

Nyholm commented Aug 2, 2016

Haha, On my way.
I have to prepend the slash there as well.

@GrahamCampbell
Copy link
Contributor

Yeh. :)

@cursedcoder cursedcoder merged commit c3929f4 into KnpLabs:master Aug 3, 2016
@Nyholm
Copy link
Collaborator Author

Nyholm commented Aug 3, 2016

Thank you for merging.

@Nyholm Nyholm deleted the urls branch August 3, 2016 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants