Skip to content

Removed setter for ApiVersion and EnterpriceUrl #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2016
Merged

Removed setter for ApiVersion and EnterpriceUrl #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions lib/Github/Client.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ public function __construct(HttpClient $httpClient = null, $apiVersion = null, $
'User-Agent' => 'php-github-api (http://github.com/KnpLabs/php-github-api)',
)));

$this->setApiVersion($apiVersion ?: 'v3');
$this->apiVersion = $apiVersion ?: 'v3';
$this->addHeaders(['Accept' => sprintf('application/vnd.github.%s+json', $this->apiVersion)]);

if ($enterpriseUrl) {
$this->setEnterpriseUrl($enterpriseUrl);
Expand Down Expand Up @@ -305,7 +306,7 @@ public function authenticate($tokenOrLogin, $password = null, $authMethod = null
*
* @param string $enterpriseUrl URL of the API in the form of http(s)://hostname
*/
public function setEnterpriseUrl($enterpriseUrl)
private function setEnterpriseUrl($enterpriseUrl)
{
$this->removePlugin(Plugin\AddHostPlugin::class);
$this->removePlugin(PathPrepend::class);
Expand Down Expand Up @@ -375,21 +376,6 @@ public function getApiVersion()
return $this->apiVersion;
}

/**
* @param string $apiVersion
*
* @return Client
*/
public function setApiVersion($apiVersion)
{
$this->apiVersion = $apiVersion;
$this->addHeaders([
'Accept' => sprintf('application/vnd.github.%s+json', $apiVersion),
]);

return $this;
}

/**
* Clears used headers.
*/
Expand Down