Add commit_message parameter on Repo::merge only if given #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you add the commit_message with null value, you will get this error: For 'properties/commit_message', nil is not a string. So the commit_message parameter has to be added only if $message is valid.
Contributor
Author
|
Any news? |
OskarStark
added a commit
to sonata-project/dev-kit
that referenced
this pull request
Sep 4, 2020
Based on code comment. KnpLabs/php-github-api#379 is merged and released
OskarStark
added a commit
to sonata-project/dev-kit
that referenced
this pull request
Sep 4, 2020
Based on code comment. KnpLabs/php-github-api#379 is merged and released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you add the commit_message with null value, you will get this error:
For 'properties/commit_message', nil is not a string.
So the commit_message parameter has to be added only if $message is valid.