Repo::all method #319
Merged
Repo::all method #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Should we really have the id argument there ? Shouldn't pagination be handled through the ResultPager instead ? |
Contributor
Author
|
I added this argument because GitHub permits it: https://developer.github.com/v3/repos/#list-all-public-repositories I think it's still useful. For me, I use it for a long command that can start on the last checked id. BTW, I follow the same method as |
Contributor
|
OK, if there is already similar things elsewhere, fine. this PR is missing tests and documentation though |
Contributor
Author
|
@stof Tests and documentation added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #294.