Fixed a load of docblocks #244
Conversation
lib/Github/Api/CurrentUser.php
Outdated
There was a problem hiding this comment.
Why did you remove this blank line and not, for example, in the diff above?
There was a problem hiding this comment.
The other's are blank lines of comment. This is just a dodgie blank line with nothing on it at all.
There was a problem hiding this comment.
I was going to send a pull request later to standardise the annotation separation.
I want to keep the PRs atomic.
There was a problem hiding this comment.
You should add the missing * instead IMO
There was a problem hiding this comment.
@stof Should I fix all cases then? There's loads of them...
There was a problem hiding this comment.
Well, I would fix this dodgie blank line in the expected way.
Then, fixing the separation of params and return values could be done in a separate PR to make it easier for maintainers to review it, or it could be included in the same PR to have everything fixed at once. I don't know what @pilot prefers
There was a problem hiding this comment.
Ping @pilot. What would you like me to do here?
There was a problem hiding this comment.
@GrahamCampbell make all in one PR, just to fix all at once pls
There was a problem hiding this comment.
Sure, will do.
lib/Github/Api/Repo.php
Outdated
There was a problem hiding this comment.
remove dot at the end for all places, looks weird
There was a problem hiding this comment.
This is happening because you're miss using the short description.
There was a problem hiding this comment.
Also, a dot is required because this is a sentence.
There was a problem hiding this comment.
@GrahamCampbell: in this case, you just need to remove the colon before the period.
There was a problem hiding this comment.
Sure I'll do a find and replace for all cases.
|
Ping @pilot. |
5 participants
No description provided.