Added ManagementConsole API and some missing tests. #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 31, 2014 09:56
… at a future date.
Contributor
There was a problem hiding this comment.
Overwriting the parent method with a different signature is a bad idea IMO. You should use a different method name instead
Contributor
Author
|
@stof thanks for the speedy and thorough review. |
Contributor
There was a problem hiding this comment.
you should check that get is called with the hash in the headers too, not only with the second argument
added 2 commits
October 31, 2014 12:08
…sh is sent with the request.
Contributor
Author
|
@stof I went ahead and added the remaining |
Contributor
Author
|
@stof anything else I need to add here? |
Contributor
Author
|
Any word on this? |
Contributor
|
@guillermoandrae I'm not a maintainer on this repo. So it is not me merging this (I just provide review on the repo to help the maintainers) |
Contributor
Author
|
Got it, @stof. Thanks very much for the feedback! Maybe @pilot or @cursedcoder ... can one of you guys take a look at this? |
Contributor
pilot
added a commit
that referenced
this pull request
Dec 10, 2014
Added ManagementConsole API and some missing tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.