Skip to content

Fix bug where null downlaods from Packagist API would result in an internal error #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2022
Merged

Fix bug where null downlaods from Packagist API would result in an internal error #85

merged 1 commit into from
Mar 3, 2022

Conversation

@robbieaverill
Copy link
Collaborator

@robbieaverill robbieaverill commented Mar 3, 2022 •
edited
Loading

@robbieaverill
Copy link
Collaborator Author

robbieaverill commented Mar 3, 2022

Hmm, $client->get('happyr/translation-bundle') returns the correct number of downloads. This means that /packages/happyr/translation-bundle.json includes this metadata but /p/happyr/translation-bundle.json does not. In this case I think we should make the downloads property nullable on Package instead of hydrating a Downloads object with 0 in it, since this is misleading.

@robbieaverill robbieaverill force-pushed the bugfix/nullable-downloads branch from b04d912 to d8dafdf Compare March 3, 2022 00:35
@robbieaverill robbieaverill force-pushed the bugfix/nullable-downloads branch from d8dafdf to bbe7d62 Compare March 3, 2022 00:39
@robbieaverill robbieaverill merged commit 7378342 into KnpLabs:master Mar 3, 2022
@robbieaverill robbieaverill deleted the bugfix/nullable-downloads branch March 3, 2022 01:19
@JellyBellyDev
Copy link
Contributor

JellyBellyDev commented Mar 3, 2022

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Downloads can be empty

2 participants

@robbieaverill @JellyBellyDev