Skip to content

fix: getComposer method #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2022
Merged

fix: getComposer method #79

merged 2 commits into from
Mar 1, 2022

Conversation

@JellyBellyDev
Copy link
Contributor

@JellyBellyDev JellyBellyDev commented Jan 27, 2022

Fixed #76
I hope :)

@JellyBellyDev JellyBellyDev force-pushed the fix/get-composer-method branch from ce680b0 to 9bc68b0 Compare January 27, 2022 17:54
@JellyBellyDev
Copy link
Contributor Author

JellyBellyDev commented Jan 27, 2022

I don't know why the CI doesn't pass, suggestions?

robbieaverill
robbieaverill reviewed Feb 14, 2022
View reviewed changes
Copy link
Collaborator

@robbieaverill robbieaverill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JellyBellyDev, I haven't forgotten about this PR, and will get to making some suggestions shortly. Thanks for making it, and sorry for the delay!

@robbieaverill robbieaverill self-assigned this Feb 22, 2022
@robbieaverill robbieaverill mentioned this pull request Mar 1, 2022
Closed
@robbieaverill
Copy link
Collaborator

robbieaverill commented Mar 1, 2022

Hi @JellyBellyDev, still working on this - I've made a couple of potential changes and am working on the tests, will post an update when I can.

@robbieaverill
Copy link
Collaborator

robbieaverill commented Mar 1, 2022

I've tested this against the behaviour in 1.7.x using the original getComposer() method added in 37a9b1e, and have put the original doc block (slightly adjusted) from that commit back in place. All looks good to me now. Thanks for your contribution @JellyBellyDev and sorry again for the time it took for me to review it.

@robbieaverill robbieaverill merged commit acf5f57 into KnpLabs:master Mar 1, 2022
JellyBellyDev
JellyBellyDev commented Mar 2, 2022
View reviewed changes
src/Packagist/Api/Client.php
$response1['packages'][$name] = [
...$response1['packages'][$name],
...$response2['packages'][$name],
];
Copy link
Contributor Author

@JellyBellyDev JellyBellyDev Mar 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!!! GJ!!! 🚀

@JellyBellyDev JellyBellyDev deleted the fix/get-composer-method branch March 2, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robbieaverill robbieaverill robbieaverill approved these changes

Assignees

@robbieaverill robbieaverill

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

getComposer is broken in 2.x-dev

2 participants

@JellyBellyDev @robbieaverill