Fix the handling of minified metadata responses #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieaverill
approved these changes
Jan 24, 2022
Collaborator
robbieaverill
left a comment
robbieaverill
left a comment
There was a problem hiding this comment.
Looks good, a lot tidier. Thank you.
robbieaverill
force-pushed
the
fix_metadata_v2
branch
from
089cb87 to
9c77567
Compare
robbieaverill
force-pushed
the
fix_metadata_v2
branch
from
9c77567 to
b8eeec1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the implementation done in #72, which was not properly expanding minified metadata, and so returning wrong results (and it was adding some unsetting to handle some of the minified structure).
This relies on the official MetadataMinifier of Composer, which is available as a dedicated package for such purpose.