Skip to content

Conversation

@sompylasar
Copy link
Contributor

  • Reworked the HTML tags library.
  • Reworked the dashboard markup to be more CSS-friendly.
  • Added visual styling with the help of materialize.css.

This PR includes #1.

Replaced the Internet CDN URLs with the URLs to local copies of the
frontend libraries served by the backend from the static content bundle.
@sompylasar
Copy link
Contributor Author

@dkorolev PTAL, I've added the static content bundler: sompylasar@b114a03
The inline CSS is still in place, the next step would be to factor it out.

@dkorolev
Copy link
Contributor

Great stuff!

Left a few comments, most are minor. Why don't you make the Bricks change as well?

The code LGTM, we'll probably merge it right away, just add a simple test.

Thanks!
Dima

@sompylasar
Copy link
Contributor Author

@dkorolev Because the change would span across branches and pull requests. I don't know yet how to do this the right way, the git-way etc.

@dkorolev
Copy link
Contributor

Bricks is virgin and free of pull requests as of now!

Me and @mzhurovich will merge the repos in ~8 days. Stay tuned!

On Sunday, May 17, 2015, John Babak [email protected] wrote:

@dkorolev https://github.com/dkorolev Because the change would span
across branches and pull requests. I don't know yet how to do this the
right way, the git-way etc.


Reply to this email directly or view it on GitHub
#2 (comment)
.

And, as always, have a nice day!
Dima

http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev |
[email protected] | +1 (312) 593 2783

@dkorolev
Copy link
Contributor

Up!

@dkorolev, on you.

@sompylasar, @mzhurovich, please make sure this pull request is not forgotten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants