Fix: Limit Non-Inline Forms per Session #951
Draft
+59
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the
data-kit-limit-per-sessionattribute was always being set totruewhen rendering the non-inline global form. It should correctly reflect the configured setting (trueorfalse).As a result, the
ck_non_inline_form_displayedcookie was also always being set, since settingdata-kit-limit-per-sessionto booleantrueorfalsecaused the related JavaScript to trigger unconditionally. This has been resolved by outputtingdata-kit-limit-per-sessionas1or0, updating the JS selector accordingly.This did not break overall functionality (since
is_script_output_limited_by_sessionwas always run to check whether all or one form should be output). However, this update ensures the logic and behavior are consistent and cleanly implemented.Testing
testNonInlineFormLimitPerSessionDoesNotSetCookieWhenDisabled: Test that theck_non_inline_form_displayedcookie is not set when the non inline form limit per session setting is disabled.Checklist