Skip to content

v4 API: Improve Subscriber Tests #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2024
Merged

v4 API: Improve Subscriber Tests #93

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
69c4cc9
Create subscriber when subscribing to resource (form, tag, sequence)
n7studios Apr 2, 2024
3803eb8
Merge remote-tracking branch 'origin/v4-api-oauth' into v4-api-improv…
n7studios Apr 2, 2024
0abfdc3
Merge remote-tracking branch 'origin/v4-api-oauth' into v4-api-improv…
n7studios Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 48 additions & 8 deletions tests/ConvertKitAPITest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,16 +1162,26 @@ public function testGetSequencesPagination()
*/
public function testAddSubscriberToSequenceByEmail()
{
// Create subscriber.
$emailAddress = $this->generateEmailAddress();
$subscriber = $this->api->create_subscriber(
email_address: $emailAddress
);

// Set subscriber_id to ensure subscriber is unsubscribed after test.
$this->subscriber_ids[] = $subscriber->subscriber->id;

// Add subscriber to sequence.
$result = $this->api->add_subscriber_to_sequence_by_email(
sequence_id: $_ENV['CONVERTKIT_API_SEQUENCE_ID'],
email_address: $_ENV['CONVERTKIT_API_SUBSCRIBER_EMAIL']
email_address: $emailAddress
);
$this->assertInstanceOf('stdClass', $result);
$this->assertArrayHasKey('subscriber', get_object_vars($result));
$this->assertArrayHasKey('id', get_object_vars($result->subscriber));
$this->assertEquals(
get_object_vars($result->subscriber)['email_address'],
$_ENV['CONVERTKIT_API_SUBSCRIBER_EMAIL']
$emailAddress
);
}

Expand Down Expand Up @@ -1218,14 +1228,23 @@ public function testAddSubscriberToSequenceByEmailWithInvalidEmailAddress()
*/
public function testAddSubscriberToSequence()
{
// Create subscriber.
$subscriber = $this->api->create_subscriber(
email_address: $this->generateEmailAddress()
);

// Set subscriber_id to ensure subscriber is unsubscribed after test.
$this->subscriber_ids[] = $subscriber->subscriber->id;

// Add subscriber to sequence.
$result = $this->api->add_subscriber_to_sequence(
sequence_id: (int) $_ENV['CONVERTKIT_API_SEQUENCE_ID'],
subscriber_id: $_ENV['CONVERTKIT_API_SUBSCRIBER_ID']
subscriber_id: $subscriber->subscriber->id
);
$this->assertInstanceOf('stdClass', $result);
$this->assertArrayHasKey('subscriber', get_object_vars($result));
$this->assertArrayHasKey('id', get_object_vars($result->subscriber));
$this->assertEquals(get_object_vars($result->subscriber)['id'], $_ENV['CONVERTKIT_API_SUBSCRIBER_ID']);
$this->assertEquals(get_object_vars($result->subscriber)['id'], $subscriber->subscriber->id);
}

/**
Expand Down Expand Up @@ -2416,14 +2435,27 @@ public function testGetResourcesInvalidResourceType()
*/
public function testAddSubscriberToFormByEmail()
{
// Create subscriber.
$emailAddress = $this->generateEmailAddress();
$subscriber = $this->api->create_subscriber(
email_address: $emailAddress
);

// Set subscriber_id to ensure subscriber is unsubscribed after test.
$this->subscriber_ids[] = $subscriber->subscriber->id;

// Add subscriber to form.
$result = $this->api->add_subscriber_to_form_by_email(
form_id: (int) $_ENV['CONVERTKIT_API_FORM_ID'],
email_address: $_ENV['CONVERTKIT_API_SUBSCRIBER_EMAIL']
email_address: $emailAddress
);
$this->assertInstanceOf('stdClass', $result);
$this->assertArrayHasKey('subscriber', get_object_vars($result));
$this->assertArrayHasKey('id', get_object_vars($result->subscriber));
$this->assertEquals(get_object_vars($result->subscriber)['id'], $_ENV['CONVERTKIT_API_SUBSCRIBER_ID']);
$this->assertEquals(
get_object_vars($result->subscriber)['email_address'],
$emailAddress
);
}

/**
Expand Down Expand Up @@ -2469,14 +2501,22 @@ public function testAddSubscriberToFormByEmailWithInvalidEmailAddress()
*/
public function testAddSubscriberToForm()
{
// Create subscriber.
$subscriber = $this->api->create_subscriber(
email_address: $this->generateEmailAddress()
);

// Set subscriber_id to ensure subscriber is unsubscribed after test.
$this->subscriber_ids[] = $subscriber->subscriber->id;

$result = $this->api->add_subscriber_to_form(
form_id: (int) $_ENV['CONVERTKIT_API_FORM_ID'],
subscriber_id: $_ENV['CONVERTKIT_API_SUBSCRIBER_ID']
subscriber_id: $subscriber->subscriber->id
);
$this->assertInstanceOf('stdClass', $result);
$this->assertArrayHasKey('subscriber', get_object_vars($result));
$this->assertArrayHasKey('id', get_object_vars($result->subscriber));
$this->assertEquals(get_object_vars($result->subscriber)['id'], $_ENV['CONVERTKIT_API_SUBSCRIBER_ID']);
$this->assertEquals(get_object_vars($result->subscriber)['id'], $subscriber->subscriber->id);
}

/**
Expand Down