Skip to content

Conversation

@n7studios
Copy link
Contributor

Summary

  • Adds sku to the products array for testing, as this is supported in the API (docs, slack)
  • Reorders create_purchase method parameters to ensure required parameters listed first
  • Removes blank and null parameters prior to calling the create purchase endpoint

Testing

  • testCreatePurchaseWithInvalidEmailAddress: Test that a ClientException is thrown when an invalid email address is specified
  • testCreatePurchaseWithBlankTransactionID: Test that a ClientException is thrown when no transaction ID defined
  • testCreatePurchaseWithNoProducts: Test that a ClientException is thrown when no products are defined

Checklist

@n7studios n7studios added this to the 2.0 milestone Mar 29, 2024
@n7studios n7studios self-assigned this Mar 29, 2024
@n7studios n7studios requested review from a team, corydhmiller and noelherrick and removed request for a team March 29, 2024 15:14
@n7studios n7studios marked this pull request as ready for review March 29, 2024 15:14
@n7studios n7studios merged commit 8354a55 into v4-api-oauth Apr 1, 2024
@n7studios n7studios deleted the v4-api-purchases-sku branch June 26, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants