Add cancel indexing #2221
Open
Add cancel indexing #2221
+493
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bcb4c69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ffinnis
force-pushed
the
add-canceling-indexing
branch
from
587c672 to
45e7c5a
Compare
|
@kevinvandijk please check my PR( |
…code into add-canceling-indexing
| if (this._cancelled) { | ||
| // Abort adding more items if cancelled | ||
| break | ||
| } |
There was a problem hiding this comment.
all these nested this._cancelled checks within this for loop seem a bit excessive. Isn't the check per block on line 195 enough here?
kevinvandijk
requested changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I really want the ability to cancel indexing without disabling it entirely. This usually happens after I’ve been working on a small project and then switch to a large codebase.
Implementation
Add a Cancel button. Show it only when the feature is enabled and indexing is in progress. Stop indexing when the _cancelled variable is set to false.
Screenshots
How to Test
Get in Touch
Discord - ffinnis (Pivo)