-
Notifications
You must be signed in to change notification settings - Fork 0
Fix four minor issues #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
22256e4 to
9b84c59
Compare
9b84c59 to
f295f3d
Compare
| ``` | ||
|
|
||
| Day in a date value. | ||
| Day in a date value, ranging from 1 to 31. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the day in the date upper limit depend on the month and on the leap / non-leap year status (for February)?
| ``` | ||
|
|
||
| Day in year in a date value. | ||
| Day in year in a date value, starting at 1 for January 1st and ending at 365 or 366 for December 31st, depending on whether it is a leap year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the upper limit determined automatically, according to the leap / non-leap year status of the specified year?
| ``` | ||
|
|
||
| Day in year in a date value. | ||
| Day in year in a date value, starting at 1 for January 1st and ending at 365 or 366 for December 31st, depending on whether it is a leap year. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/on whether it is a leap year/on whether it is a leap year or not/
| Year in a date value, with decimal part for day in year. | ||
| Year in a date value, including a decimal part representing the day of the year. | ||
|
|
||
| Precisely, `DecimalYear = Year + (YearDay-1)/365` (or 366 for leap years). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the denominator determined automatically, depending on the leap / non-leap status of the specified Year?
| - the label must appear on the same line immediately after the variable definition, | ||
| - the label is the first commented line before the dictionary definition, | ||
|
|
||
| - comments are the next commented lines before the dictionary definition; they can be interspersed with dictionary definition fragments (e.g. key, meta-data), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra space between "e.g." and "key".
| Second in a time value. | ||
| Second in a time value, ranging from 0 to 59.999. | ||
|
|
||
| Note: seconds can be precise up to one thousandth of a second (i.e., milliseconds). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reformat to:
!!! note
Seconds can be precise up to one thousandth of a second (i.e., milliseconds).Thus, the note is rendered like in e.g.: https://khiops.org/11.0.0-b.0/tutorials/scenario/.
| ``` | ||
|
|
||
| Decimal day in a time value, between 0.0 and 23.9999. | ||
| Decimal representation of the time within a day, ranging from 0.0 to just under 24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "just under 24.0": up to which precision?
| Year in a timestamp value, with decimal part for day in year, at a timestamp precision. | ||
| Year in a timestamp value, including a decimal part for the day of the year and the time of day. | ||
|
|
||
| Precisely, `DecimalYearTS = Year + (YearDay-1 + DecimalTime(time)/24)/365` (or 366 for leap years). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the denominator determined automatically according to the leap / non-leap status of the Year?
|
|
||
|  | ||
|
|
||
| For details on each construction rule, see the related derivation rule. For example, to learn about WeekDay, visit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would format WeekDay: `Weekday`
| - tokens : text tokens whose interpretability and interest depend on the quality of the input text preprocessing. | ||
|
|
||
| The **words** automatic tokenization process uses separator or control characters as delimiters. | ||
| The **words** automatic tokenization process uses space or control characters as delimiters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have the documented list (or regular expression, or code range) of these control characters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments.
No description provided.