This repository was archived by the owner on Jan 25, 2025. It is now read-only.
Username and email display behavior #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
The existing "Email as username" behavior is confusing. Time to fix that.
💡 Proposed solution
- Check for "Email as username" state. If checked, set username field to "null" upon item save only (prevents accidental erasure).a. Achieve parity with Keyspace browser plugin(s).
b. Simplify the process of adding a login by preventing unnecessary and confusing options.
📋 Release Notes
Testing
- Edit the login, check the "Email as username" switch, save it and observe again.