Skip to content
This repository was archived by the owner on Jan 25, 2025. It is now read-only.

Conversation

@0x4f53
Copy link
Member

@0x4f53 0x4f53 commented Jan 12, 2023

♻️ Current situation

The existing "Email as username" behavior is confusing. Time to fix that.

💡 Proposed solution

- Check for "Email as username" state. If checked, set username field to "null" upon item save only (prevents accidental erasure).

  • Remove the "Email as username" switch to:
    a. Achieve parity with Keyspace browser plugin(s).
    b. Simplify the process of adding a login by preventing unnecessary and confusing options.
  • If both email and username are set, prioritize username (helps with sites like reddit).

📋 Release Notes

  • Changed username-email behavior to prioritize usernames in UI if set.
  • Removed the "Email as username" switch

Testing

  • Create a login with username and email and save it and observe the login card: the username is shown in the dashboard card but they're both displayed in the mini login dialog.
  • Create a login with an username only and save it. Only the username is shown in both the login card and the mini dialog.
  • Create a login with an email only and save it. Only the email is shown in both the login card and the mini dialog.
  • Create a login with a name only and save it. Neither the email nor the username is shown in both the login card and the mini dialog.
    - Edit the login, check the "Email as username" switch, save it and observe again.

@0x4f53 0x4f53 added the enhancement New feature or request label Jan 12, 2023
@0x4f53 0x4f53 requested a review from nimish-ks January 12, 2023 14:29
@0x4f53 0x4f53 requested a review from a user January 12, 2023 14:29
@0x4f53 0x4f53 assigned ghost and unassigned rohan-chaturvedi Jan 12, 2023
@0x4f53 0x4f53 added the bug Something isn't working label Jan 12, 2023
@0x4f53 0x4f53 changed the title Usernames on dashboard Username and email display behavior Jan 19, 2023
@rohan-chaturvedi rohan-chaturvedi self-requested a review February 1, 2023 07:01
@rohan-chaturvedi rohan-chaturvedi removed the bug Something isn't working label Feb 1, 2023
@rohan-chaturvedi rohan-chaturvedi merged commit a44ed77 into v1.4.2 Feb 1, 2023
@rohan-chaturvedi rohan-chaturvedi deleted the usernames_on_dashboard branch February 1, 2023 07:47
@rohan-chaturvedi rohan-chaturvedi mentioned this pull request Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants