Skip to content
This repository was archived by the owner on Jan 25, 2025. It is now read-only.

Conversation

@0x4f53
Copy link
Member

@0x4f53 0x4f53 commented Jan 12, 2023

♻️ Current situation

App doesn't support 19 digit credit cards (like Maestro)

💡 Proposed solution

  • Add support for adding 19-digit cards.
  • Update app UX to support 19-digit cards.

📋 Release Notes

  • Added support for 19-digit cards.
  • Fix dashboard card to display more digits by moving them to the next line instead of showing ellipses.
  • Add Maestro card to payment gateway detector.
  • Updated validation for 16 to 19 digit cards.

➕ Additional Information

#44

📝 Testing

  1. Try saving a 16 digit card. Observe usual spacing behavior.
  2. Add 3 more digits to the card number. Observe how the spacing vanishes.
  3. Remove the spacing from the end. Observe how 16-digit spacing reappears.
  4. Save a card and try editing it. Notice how the card number formatting is preserved visually.
  5. When testing 19-digit cards on narrow length devices (E.g.: the front display of a Samsung Galaxy Fold, notice how the card information is multiline).

@0x4f53 0x4f53 linked an issue Jan 12, 2023 that may be closed by this pull request
@0x4f53 0x4f53 added the enhancement New feature or request label Jan 12, 2023
@0x4f53 0x4f53 requested a review from nimish-ks January 12, 2023 14:29
@rohan-chaturvedi rohan-chaturvedi self-requested a review January 29, 2023 15:16
@rohan-chaturvedi rohan-chaturvedi merged commit 542786d into v1.4.2 Feb 1, 2023
@rohan-chaturvedi rohan-chaturvedi deleted the 19_digit_cards branch February 1, 2023 07:47
@rohan-chaturvedi rohan-chaturvedi mentioned this pull request Feb 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Increase card digits maximum limit

4 participants