-
Notifications
You must be signed in to change notification settings - Fork 13
feat(cli): generate Json Schema #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2d55868
91dd7c9
dc6b00d
ba0ab05
ac50272
ccf9531
5128da5
7303f23
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| [workspace] | ||
| members = ["cli"] | ||
| members = ["cli", "schema"] | ||
| resolver = "2" | ||
|
|
||
| [workspace.package] | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pub mod config; | ||
| pub mod git; | ||
| pub mod message; | ||
| pub mod result; | ||
| pub mod rule; |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -5,6 +5,7 @@ use super::Level; | |||||
|
|
||||||
| /// DescriptionEmpty represents the subject-empty rule. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fix incorrect documentation. The struct documentation incorrectly states "DescriptionEmpty represents the subject-empty rule" when it should be "description-empty rule". Apply this fix: - /// DescriptionEmpty represents the subject-empty rule.
+ /// DescriptionEmpty represents the description-empty rule.📝 Committable suggestion
Suggested change
|
||||||
| #[derive(Clone, Debug, Deserialize, Serialize)] | ||||||
| #[cfg_attr(feature = "schemars", derive(schemars::JsonSchema))] | ||||||
| pub struct DescriptionEmpty { | ||||||
| /// Level represents the level of the rule. | ||||||
| /// | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Documentation needed for the
schemarsfeature flagThe optional dependency is well-implemented, but it lacks documentation. Please add documentation in the README.md or cli/README.md explaining:
schemarsfeature flag🔗 Analysis chain
LGTM! Well-structured feature flag implementation.
The optional dependency and feature flag setup looks good. Making
schemarsoptional and not enabled by default is the right approach since schema generation is a development-time feature.Let's verify that the feature flag is properly documented:
Also applies to: 33-35
Let me check if there's any documentation about this feature in other common documentation locations before making the final response.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 136
Script:
Length of output: 164