Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 22 additions & 11 deletions src/rule/description_max_length.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,12 @@ impl Rule for DescriptionMaxLength {
}

fn validate(&self, message: &Message) -> Option<Violation> {
match &message.description {
Some(desc) => {
if desc.len() >= self.length {
return Some(Violation {
level: self.level.unwrap_or(Self::LEVEL),
message: self.message(message),
});
}
}
None => {
if let Some(desc) = &message.description {
if desc.len() >= self.length {
return Some(Violation {
level: self.level.unwrap_or(Self::LEVEL),
message: self.message(message),
})
});
}
}

Expand Down Expand Up @@ -80,6 +72,25 @@ mod tests {
assert!(rule.validate(&message).is_none());
}

#[test]
fn test_empty_description() {
let rule = DescriptionMaxLength {
length: 10, // Short length for testing
..Default::default()
};
let message = Message {
body: None,
description: None,
footers: None,
r#type: Some("feat".to_string()),
raw: "feat(scope)".to_string(),
scope: Some("scope".to_string()),
subject: None,
};

assert!(rule.validate(&message).is_none());
}

#[test]
fn test_short_description() {
let rule = DescriptionMaxLength {
Expand Down