Skip to content

feat(config): add github releases flow #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 15, 2024
Merged

feat(config): add github releases flow #221

merged 7 commits into from
Jan 15, 2024

Conversation

@suyulin
Copy link
Contributor

@suyulin suyulin commented Nov 11, 2023 •
edited
Loading

ref #45 adn #46

KeisukeYamashita
KeisukeYamashita reviewed Nov 13, 2023
View reviewed changes
Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I'll take a look with in a week 🙏

@KeisukeYamashita
Copy link
Owner

KeisukeYamashita commented Nov 29, 2023

I'm so sorry for the late reply! I will indeed check this week 🙏 🙇
Sorry for your inconvenience.

KeisukeYamashita
KeisukeYamashita requested changes Dec 2, 2023
View reviewed changes
Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the current flow, softprops/action-gh-release will be executed for each matrix and it would be overwritten?

@KeisukeYamashita
Copy link
Owner

KeisukeYamashita commented Jan 10, 2024

Sorry for the late response, I'll check this week 🙏

KeisukeYamashita
KeisukeYamashita approved these changes Jan 15, 2024
View reviewed changes
Copy link
Owner

@KeisukeYamashita KeisukeYamashita left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much, let me update the details 🙏
And sorry for getting late 🙏

@KeisukeYamashita KeisukeYamashita merged commit 1455f14 into KeisukeYamashita:main Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KeisukeYamashita KeisukeYamashita KeisukeYamashita approved these changes

Assignees

@suyulin suyulin

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suyulin @KeisukeYamashita