Bower: Resolve bower install conflicts #416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve conflicts with bower install to permit non-interactive build.
abridger
reviewed
Dec 20, 2017
bower.json
Outdated
| "iron-image": "PolymerElements/iron-image#^1.2.5" | ||
| }, | ||
| "resolutions": { | ||
| "iron-image": "^2.1.2", |
There was a problem hiding this comment.
Rather than specifying this in the resolutions, perhaps we could just bump the dependency version to 2.x above? Otherwise this all looks fine.
There was a problem hiding this comment.
@pazdera It was your work, I just committed it :p What do you think?
There was a problem hiding this comment.
@abridger Good point.
@tombettany Alan's right. Just remove the resolution and update the dependency.
abridger
approved these changes
Dec 22, 2017
paulvarache
pushed a commit
that referenced
this pull request
May 6, 2019
Bower: Resolve bower install conflicts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve conflicts with bower install to permit non-interactive build.