Speed up load times #404
Merged
Speed up load times #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombettany
approved these changes
Jun 7, 2017
kano_draw/server.py
Outdated
|
|
||
| def _get_image_from_str(img_str): | ||
| ''' | ||
| Create a unique filename that points to img_str |
There was a problem hiding this comment.
This actually encodes the provided image in base64 and returns that string. Might be worth making the comment accurate.
|
Thanks! Fixed and merging. |
paulvarache
pushed a commit
that referenced
this pull request
May 6, 2019
* Speed up load times * Rectified function comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On initial load, the application was copying and synchronizing local and remote web content.
This had the side effect of slowing down response times considerably.
Fixed by simply loading the packaged version of the content, as we don't really upgrade the remote version.
@tombettany