Skip to content

GTM tag, remove segment.io #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2016
Merged

GTM tag, remove segment.io #327

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions lib/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
* Define behaviour for app `run` and `config`
*/

var api, auth, cfg, envCfg, tracking,
var api, auth, cfg, envCfg,
config = require('./core/config'),
analytics = require('./core/analytics'),
app = angular.module('draw', ['ngRoute']),
Expand All @@ -21,7 +21,6 @@ envCfg = {

auth = require('./core/auth')(envCfg);
api = require('./api')(envCfg);
tracking = require('./core/tracking');

window.CONFIG = cfg;
domainCfg = cfg.DOMAIN_CFG;
Expand Down Expand Up @@ -137,9 +136,6 @@ app.run(function ($rootScope, $window) {

initProgress();


tracking.init();

// Initialised auth state
auth.init(function () {
var userObj, userId;
Expand Down
13 changes: 5 additions & 8 deletions views/index.jade
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,16 @@ html(lang='en', xmlns:ng="http://angularjs.org")
script(src='/js/vendor/xtag.js')

body(id="ng-app", ng-app='draw', class=offline ? 'offline' : 'online')
// Google Tag Manager
//- Google Tag Manager
noscript
iframe(src='//www.googletagmanager.com/ns.html?id=discover-kano', height='0', width='0', style='display:none;visibility:hidden')
script.
iframe(src='//www.googletagmanager.com/ns.html?id=GTM-WMGKFR', height='0', width='0', style='display: none; visibility: hidden;')
script(type='text/javascript').
(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'//www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','discover-kano');
// End Google Tag Manager
})(window,document,'script','dataLayer','GTM-WMGKFR');
//- End Google Tag Manager

script(src='/js/vendor/console-polyfill.js', type='text/javascript')
.loading-overlay(ng-cloak): .spinner
Expand All @@ -55,9 +55,6 @@ html(lang='en', xmlns:ng="http://angularjs.org")
script(src='/js/vendor/angular-route.min.js', type='text/javascript')
script(src='/js/vendor/ace/ace.js', type='text/javascript')
script(src='/js/vendor/ace/ext-language_tools.js', type='text/javascript')
//- Analytics
if segmentioId
script(src='/js/vendor/segmentio.min.js', type='text/javascript')

script(type='text/javascript').
window.ENV = '#{env}';
Expand Down