Skip to content

Conversation

@djherbis
Copy link
Contributor

Adds widget support for matplotlib

http://b/185060120

Adds widget support for matplotlib

http://b/185060120
@djherbis djherbis requested a review from rosbo April 12, 2021 16:14
@djherbis
Copy link
Contributor Author

Needed for https://github.com/Kaggle/kaggleazure/pull/15395 to work out of the box on our env

Dockerfile Outdated
# Keep JAX version in sync with GPU image.
pip install jax==0.2.12 jaxlib==0.1.64 && \
# ipympl adds interactive widget support for matplotlib
pip install ipympl && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably hard to add a test for this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I don't think theres a way to test an interactive widget like this :(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a version pin to make sure it stays compatible

Version needs to match the version installed statically in the editor.
https://github.com/matplotlib/ipympl#install-an-old-jupyterlab-extension
@djherbis djherbis merged commit e70e239 into master Apr 12, 2021
@djherbis djherbis deleted the jupyter-matplotlib branch April 12, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants