Skip to content

Conversation

@rosbo
Copy link
Contributor

@rosbo rosbo commented Dec 15, 2020

Fixes #909.

Also updated the tests to load datasets from a csv file rather than a binary file. Using .csv files is more portable and avoid errors when changing versions:

lightgbm.basic.LightGBMError: Input file is not LightGBM binary file

BUG=175727746

@rosbo rosbo requested a review from Philmod December 15, 2020 23:30
@rosbo
Copy link
Contributor Author

rosbo commented Dec 15, 2020

cc/ @marketneutral

Fixes #909.

BUG=175727746
The binary format is not meant to be compatible between versions.
@rosbo rosbo merged commit 915befa into master Dec 16, 2020
@rosbo rosbo deleted the upgrade-lightgbm branch December 16, 2020 23:01
@marketneutral
Copy link
Contributor

Thanks so much for this. I checked Kaggle today and I don't see that this has been deployed yet. Do you think this will be deployed before year end?

@Philmod
Copy link
Contributor

Philmod commented Dec 21, 2020

Thanks so much for this. I checked Kaggle today and I don't see that this has been deployed yet. Do you think this will be deployed before year end?

Hi @marketneutral, these changes won't be deployed before next year unfortunately.

@marketneutral
Copy link
Contributor

Hi @Philmod ... would it be possible to release this to Kaggle notebooks this week? I'd like to use it in a current competition.

@rosbo
Copy link
Contributor Author

rosbo commented Jan 12, 2021

Hi @marketneutral,

As soon as #932 is in. We will cut a new release. The release should be deployed to production this week.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

please bump LightGBM from 2.3.1 to 3.0.0

4 participants