Add new client to retrieve exportable .ipynb of current session. #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
http://b/171318603
Contributor
Author
|
cc/ @pavithrasv |
ifigotin
approved these changes
Oct 20, 2020
Contributor
ifigotin
left a comment
ifigotin
left a comment
There was a problem hiding this comment.
LGTM
I'm not sure if you'd like a test for this (the main functionality is in web_client), but maybe you'd add one later if this gets more complicated.
Contributor
Author
|
Good point. I will add one now even if it is super simple so the foundation is there to add more as we add more complex methods to this file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://b/171318603