Skip to content

Conversation

@develra
Copy link
Contributor

@develra develra commented Nov 18, 2024

I think this will break qgrid fwiw, unsure how often that is used.

@develra develra requested review from calderjo and djherbis November 18, 2024 22:30
@calderjo
Copy link
Contributor

currently main build is broken, will ptal to see if i can fix it.

not too sure if qgrid is used for other packages, we'll need to see if it affect other things

@calderjo
Copy link
Contributor

calderjo commented Nov 25, 2024

i think jim mentioned that using the pretest image which has this version did not seem to fix the widget issue, right?
Do we still want this upgrade? @develra @jeward414

calderjo and others added 2 commits November 25, 2024 23:39
fixing main build.
- kagglehub login changes required updating our tests
- latest matplotlib is needed by handful of package, but breaks
learntools. i provided a workaround
@calderjo calderjo changed the base branch from main to add-gcvit-to-kaggle-docker-image November 26, 2024 00:31
@calderjo calderjo changed the base branch from add-gcvit-to-kaggle-docker-image to main November 26, 2024 00:31
@calderjo
Copy link
Contributor

calderjo commented Nov 26, 2024

added a change to remove qgrid, checked the package usage, little to no usage.

i will removed qgrid along with test, so that it doesn't block this upgrade

@calderjo calderjo merged commit 03c832e into main Nov 26, 2024
4 checks passed
@calderjo calderjo deleted the ipywidgets-upgrade branch November 26, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants