Skip to content

Conversation

@calderjo
Copy link
Contributor

@calderjo calderjo commented Feb 8, 2024

this is based on original rosbo pr for keras-3 to upgrade to keras 3

key things:

  • a patch was added (commit) to address unreleased version of tf-df (short term in-order to unblock upcoming project)
  • tensorflowjs along with its test was removed

http://b/318672158
passes:
https://ci.kaggle.net/job/kernels/job/docker-python/job/upgrade-keras-3/

cc: @jplotts

@calderjo calderjo marked this pull request as ready for review February 8, 2024 10:01
@calderjo calderjo requested a review from djherbis February 8, 2024 10:07
@calderjo
Copy link
Contributor Author

calderjo commented Feb 8, 2024

btw had some trouble figuring out git rebase via cli, create a new different branch and forgot to remove the tfjs test, which caused it to failed. it been removed we should expect tests to pass, the o.g branch did pass.

@calderjo calderjo requested review from djherbis and removed request for djherbis February 8, 2024 20:17
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work mate, super cool to see this build/pass tests.

@calderjo calderjo merged commit 9c637d1 into main Feb 8, 2024
@calderjo calderjo deleted the upgrade-keras-3 branch February 8, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants