Skip to content

Conversation

@rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Apr 3, 2023

re/ KILTProtocol/ticket#2264

Updates GitHub workflows to no longer use deprecated actions and features which will be retired shortly.

How to test:

Run as many workflows as possible I guess.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@rflechtner rflechtner requested a review from ggera April 4, 2023 09:02
@rflechtner rflechtner changed the title chore: update GitHub workflows ci: update GitHub workflows Apr 4, 2023
Copy link
Member

@ggera ggera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the node-version upgraded accross the board? if so there are places where it's still 14

- name: Use Node.js 14
uses: actions/setup-node@v3
with:
node-version: 14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: 14
node-version: 16

- name: Use Node.js 14
uses: actions/setup-node@v3
with:
node-version: 14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: 14
node-version: 16

- name: Use Node.js 14
uses: actions/setup-node@v3
with:
node-version: 14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node-version: 14
node-version: 16

@rflechtner
Copy link
Contributor Author

is the node-version upgraded accross the board? if so there are places where it's still 14

I haven't actually updated the node version of our build/test jobs, just the actions that were still using node v12. I'd do that in a separate PR so it's easier to revert if something breaks.

@rflechtner rflechtner merged commit b8cf0bd into develop Apr 6, 2023
@rflechtner rflechtner deleted the rf-update-wfs branch April 6, 2023 06:52
rflechtner added a commit that referenced this pull request May 23, 2023
rflechtner added a commit that referenced this pull request May 23, 2023
rflechtner added a commit that referenced this pull request May 23, 2023
@rflechtner rflechtner mentioned this pull request May 24, 2023
27 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants