Skip to content

Conversation

@ChrisChinchilla
Copy link

fixes KILTProtocol/ticket#3594

Chris Chinchilla added 4 commits September 30, 2024 12:38
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla changed the base branch from master to sdk-v1 October 24, 2024 15:03
Signed-off-by: Chris Chinchilla <[email protected]>
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some nitpicks remaining

@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review October 31, 2024 09:44
@ChrisChinchilla
Copy link
Author

@rflechtner If you're good with it now, let's get this merged into the SDK branch and I will fix the code transclusion now.

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@ChrisChinchilla ChrisChinchilla merged commit 232c02b into sdk-v1 Oct 31, 2024
0 of 5 checks passed
@ChrisChinchilla ChrisChinchilla deleted the 3594-update-workshop branch October 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants