Fix setting of response body for StatusError exception #975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in JuliaCloud/AWS.jl#593, the recently refactored retry logic was failing to properly write the response body when a `response_stream` was used and a `StatusError` was thrown.
nickrobinson251
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## master #975 +/- ##
==========================================
- Coverage 79.84% 79.83% -0.02%
==========================================
Files 36 36
Lines 2967 2970 +3
==========================================
+ Hits 2369 2371 +2
- Misses 598 599 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thanks @quinnj, this fixes all the problems we were seeing on our end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in JuliaCloud/AWS.jl#593, the recently refactored retry logic was failing to properly write the response body when a
response_streamwas used and aStatusErrorwas thrown.