Set timeout limit for tests #739
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 76.89% 76.89%
=======================================
Files 38 38
Lines 2445 2445
=======================================
Hits 1880 1880
Misses 565 565 Continue to review full report at Codecov.
|
|
@quinnj @StefanKarpinski It would be good to get this merged. The specific value of the timeout can always be increased later, but anything is better than GitHub's default of 6 hours. |
DilumAluthge
approved these changes
Aug 24, 2021
|
The immediate concern has been fixed in #745, where I fixed the websocket tests that were just hanging forever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to recent runs taking 6 hours on nightly.